Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint to 7 and associated dependencies #661

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 3, 2020

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv requested a review from jotoeri November 3, 2020 15:28
@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Nov 3, 2020
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hui, quite many... 👍
I didn't test now, but i assume everything still works...?

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@jotoeri
Copy link
Member

jotoeri commented Nov 12, 2020

Just rebased this and tested. Everything still seems to work.
Anything preventing merge @skjnldsv ?

@skjnldsv
Copy link
Member Author

Just rebased this and tested. Everything still seems to work.
Anything preventing merge @skjnldsv ?

I forgot about this or 🙈

@jotoeri jotoeri merged commit 5c82184 into master Nov 13, 2020
@jotoeri jotoeri deleted the feat/eslint-7 branch November 13, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants