Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix question icons broken in dark theme #312

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix question icons broken in dark theme #312

merged 1 commit into from
Apr 29, 2020

Conversation

skjnldsv
Copy link
Member

Capture d’écran_2020-04-29_12-24-49

@skjnldsv
Fix question icons broken in dark theme
8dfcfcb 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Apr 29, 2020
@skjnldsv skjnldsv self-assigned this Apr 29, 2020
jotoeri
jotoeri approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how it looked before, but looks good. ;)

@skjnldsv
Copy link
Member Author

Don't know how it looked before, but looks good. ;)

Only the two first were inverted
image

@skjnldsv skjnldsv merged commit 76e36a2 into master Apr 29, 2020
@skjnldsv skjnldsv deleted the fix/questions-icons branch April 29, 2020 10:42
@jancborchardt
Copy link
Member

Just noticed – the primary button icon (and text) should be white in the dark theme as well, as otherwise it's not enough contrast.

@skjnldsv
Copy link
Member Author

@jancborchardt can you add that to the list so it's not lost? :)

@jancborchardt
Copy link
Member

jancborchardt commented Apr 29, 2020 •
edited
Loading

@jancborchardt can you add that to the list so it's not lost? :)

Isn't it an issue for the Vue repository?
Anyway, will add to the list.

@skjnldsv
Copy link
Member Author

No, we're enfocring the icon with ours :)
It won't be an issue anymore with the icon library though ;) (since we'd be able to use css color)

@jancborchardt jancborchardt added this to the 2.0 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotoeri jotoeri jotoeri approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @jancborchardt @jotoeri