fix: Handle questions props as props and not as attrs #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
commented
Oct 25, 2023
Chartman123
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good, couldn't find any problems when testing the frontend.
What I noticed in edit view: As soon as you enter edit mode for the title or a question, all fields switch to edit mode. Is this intended as a preparation of implementing the a11y improvements?
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/props-and-attrs
branch
from
925e895 to
654aac4
Compare
|
Squashed and fixed the commend, good to merge now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed errors reported in dev console:
We should handle properties as properties and no as attributes.
This also refactors the code a bit to remove code duplication across questions.