-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Replace confirm dialog for deletion with NcDialog #1663
Conversation
@susnux I had a conversation with @jotoeri about the issue behind this PR and about what he meant with "destructiveDialog". He told me that his intention was to have a standard way for this type of dialog in nextcloud-dialogs and that he already created two issues there. nextcloud-libraries/nextcloud-dialogs#300 What do you think about that? |
c1e303c
to
13fe22a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
============================================
- Coverage 44.59% 40.05% -4.54%
+ Complexity 657 562 -95
============================================
Files 58 55 -3
Lines 2592 2379 -213
============================================
- Hits 1156 953 -203
+ Misses 1436 1426 -10 |
13fe22a
to
ea79f82
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
ea79f82
to
5506552
Compare
@susnux now that nextcloud-libraries/nextcloud-dialogs#1297 is merged: should we adjust this for Forms to the new dialog? |
We can but not necessary - I am not sure whats cleaner. Meaning work to put into it and if the code outcome is cleaner than the current? |
Fixes #762