-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement custom submission message #1659
Conversation
5cd7610
to
b03d290
Compare
@susnux Nice addition :) Should we hide the message input field behind a switch? [ ] Show custom message |
c797fd2
to
72f8798
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
============================================
- Coverage 43.19% 42.96% -0.24%
- Complexity 611 613 +2
============================================
Files 57 58 +1
Lines 2475 2486 +11
============================================
- Hits 1069 1068 -1
- Misses 1406 1418 +12 |
Unsure about this, what do you think looks better? (For me both variants have equal pros and cons) |
Using the switch we would surely need one more column in the DB, but then could also have an empty submission message. I think this is also a question for the designers. If we add the switch, we should also indent the text box under the text of the switches. Would you like to bring it up in the design team chat? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea @susnux! And yep, I think @Chartman123’s suggestion about doing it as a switch is good, keeps it cleaner too since most people are likely to keep the original submission message. And then we can also add some grey hint text when it’s enabled saying something like:
"Message to show after form submission. Note that this can not be translated."
72f8798
to
a772483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another look at the corresponding issue and saw that there was a request for customizing the title message of the submission page, too. Would you like to add this into this PR as well?
Other than that, please update the API docs :)
a7523e5
to
cf134e5
Compare
cf134e5
to
8c2beb9
Compare
@jancborchardt the setting do look like this now: |
Looks good now. So only the following things are remaining:
|
8c2beb9
to
7e5b431
Compare
@Chartman123 done with the todos
I would say no as we did not change it, there are no new routes, we did not increase the API level for new option keys before (e.g.
can we do this in a follow up? I would like to discuss some options before and this PR at least provides the functionality requested. |
7e5b431
to
99c1aba
Compare
I'm no expert in API level definitions... But fine for me to stay with 2.1
Fine for me 👍🏻 |
267e690
to
812a637
Compare
This message is shown when a user submits the form and can be formatted using markdown. Make the custom submission message hidden behind a checkbox Null on submissionMessage means disabled Co-authored-by: Chartman123 <chris-hartmann@gmx.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
812a637
to
fed3d4c
Compare
ℹ️ Summary
Users can configure a custom text which is shown if a users submits the form (custom "Thank you message").
It can be formatted using markdown, so it also allows the requested link feature (e.g. to link back to a website).
🖼️ Screenshots