Make skip to content buttons work #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
============================================
+ Coverage 39.56% 40.17% +0.60%
- Complexity 556 560 +4
============================================
Files 53 54 +1
Lines 2320 2367 +47
============================================
+ Hits 918 951 +33
- Misses 1402 1416 +14 |
Chartman123
approved these changes
Feb 21, 2023
jancborchardt
approved these changes
Feb 22, 2023
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/skip-buttons
branch
from
eb40098 to
b104b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1259
Set correct IDs for the shortcut links, and removed the navigation link for public shares (there is no app navigation):
Before
(Notice how the buttons do not work)
vokoscreenNG-2023-02-21_15-06-08.mp4
After
vokoscreenNG-2023-02-21_15-08-14.mp4