-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust styling for NC25 & Update @nextcloud/vue
#1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was intended until now, to keep the support for NC<25. But with some information from today about NC wanting to promote forms further, seems like this is necessary. Also if i'm not really happy with it tbh.
Few small things on the css, then i think we can go with this.
Any problems with this regarding the compatibility with NC24? |
Maybe do it like the text app is maintaining different branches for old versions? Like branching before this and then only doing fixes for old stable and features into current stable.
The top bar is off center: voko.mp4 |
Yes that's the way we're planning to go now, too. Version 3.0 will have minversion 25. So all the design changes and new features will only be available in NC25+. |
6f5bfeb
to
32ec41d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thought, but no blocker anymore. 👍
* Update `@nextcloud/vue` to version 7.0.0-beta.3 to support the latest changes of the nc frontend (appcontent as scoll container) * Adjusted the styling of the TopBar and views accordingly Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Currently forms is somewhat broken for the current NC master (or 25 beta), as the topbar is rendered inside the navigation menu.
This fixes the compatibility with the upcoming NC, but probably breaks the compatibility with anything below 25.
@nextcloud/vue
to version 7.0.0-beta.3 to support the latest changes of the nc frontend inserver
(appcontent
as scroll container)Without this it looks like this on NC25 (especially the toolbar on the top right):
