Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust styling for NC25 & Update @nextcloud/vue #1338

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Adjust styling for NC25 & Update @nextcloud/vue #1338

merged 1 commit into from
Sep 20, 2022

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Sep 14, 2022

Currently forms is somewhat broken for the current NC master (or 25 beta), as the topbar is rendered inside the navigation menu.
This fixes the compatibility with the upcoming NC, but probably breaks the compatibility with anything below 25.

  • Update @nextcloud/vue to version 7.0.0-beta.3 to support the latest changes of the nc frontend in server (appcontent as scroll container)
  • Adjusted the styling of the TopBar and views accordingly

Without this it looks like this on NC25 (especially the toolbar on the top right):
toolbar is overlapping the navigation

Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intended until now, to keep the support for NC<25. But with some information from today about NC wanting to promote forms further, seems like this is necessary. Also if i'm not really happy with it tbh.

Few small things on the css, then i think we can go with this.

@Chartman123
Copy link
Collaborator

Any problems with this regarding the compatibility with NC24?

@susnux
Copy link
Collaborator Author

susnux commented Sep 14, 2022

keep the support for NC<25

Maybe do it like the text app is maintaining different branches for old versions? Like branching before this and then only doing fixes for old stable and features into current stable.
But not sure how complex that would be and if this is a possible option for forms.

Any problems with this regarding the compatibility with NC24?

The top bar is off center:

voko.mp4

@Chartman123
Copy link
Collaborator

maintaining different branches

Yes that's the way we're planning to go now, too. Version 3.0 will have minversion 25. So all the design changes and new features will only be available in NC25+.

@Chartman123 Chartman123 added this to the 3.0 milestone Sep 15, 2022
@susnux susnux force-pushed the nc25 branch 3 times, most recently from 6f5bfeb to 32ec41d Compare September 20, 2022 10:37
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thought, but no blocker anymore. 👍

@jotoeri jotoeri requested a review from Chartman123 September 20, 2022 11:10
* Update `@nextcloud/vue` to version 7.0.0-beta.3 to support
  the latest changes of the nc frontend (appcontent as scoll container)
* Adjusted the styling of the TopBar and views accordingly

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@Chartman123 Chartman123 added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 20, 2022
@jotoeri jotoeri merged commit 1a48f47 into master Sep 20, 2022
@jotoeri jotoeri deleted the nc25 branch September 20, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants