-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Content to Vue #1321
Empty Content to Vue #1321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
============================================
- Coverage 36.91% 36.83% -0.08%
- Complexity 506 507 +1
============================================
Files 47 47
Lines 1956 1960 +4
============================================
Hits 722 722
- Misses 1234 1238 +4 |
f011eac
to
369cbef
Compare
@jotoeri: I just tried to see the second screenshot (epired form) in action and went directly to the submit-route of one of my expired forms. However, I could see the form and the submit button and then get a 403 when I wanted to submit the form. Do we have a bug there? |
On the public share links they both seemed to work. Should we make them also working for the internal links? |
369cbef
to
188835c
Compare
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
416f973
to
3c7f23c
Compare
Hmm, yes, probably we missed that. But seems like this will be solved with #1320 then. This PR is more the technical part to move the templates to a vue-component. So only on public view. |
Moving the empty-content templates to a small vue-script, due to missing icon-classes in NC25.