Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Content to Vue #1321

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Empty Content to Vue #1321

merged 1 commit into from
Sep 6, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Sep 1, 2022

Moving the empty-content templates to a small vue-script, due to missing icon-classes in NC25.

grafik
grafik

@jotoeri jotoeri changed the title Enh/empty vue Empty Content to Vue Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1321 (3c7f23c) into master (fdade81) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1321      +/-   ##
============================================
- Coverage     36.91%   36.83%   -0.08%     
- Complexity      506      507       +1     
============================================
  Files            47       47              
  Lines          1956     1960       +4     
============================================
  Hits            722      722              
- Misses         1234     1238       +4     

@jotoeri jotoeri force-pushed the enh/empty_vue branch 2 times, most recently from f011eac to 369cbef Compare September 1, 2022 21:04
@jotoeri jotoeri changed the base branch from fix/even_more_icons to master September 1, 2022 21:05
@jotoeri jotoeri marked this pull request as ready for review September 1, 2022 21:06
@jotoeri jotoeri added 3. to review Waiting for reviews technical debt Technical issue labels Sep 1, 2022
@Chartman123
Copy link
Collaborator

@jotoeri: I just tried to see the second screenshot (epired form) in action and went directly to the submit-route of one of my expired forms. However, I could see the form and the submit button and then get a 403 when I wanted to submit the form. Do we have a bug there?

@Chartman123
Copy link
Collaborator

On the public share links they both seemed to work. Should we make them also working for the internal links?

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Member Author

jotoeri commented Sep 5, 2022

@jotoeri: I just tried to see the second screenshot (epired form) in action and went directly to the submit-route of one of my expired forms. However, I could see the form and the submit button and then get a 403 when I wanted to submit the form. Do we have a bug there?

Hmm, yes, probably we missed that. But seems like this will be solved with #1320 then. This PR is more the technical part to move the templates to a vue-component. So only on public view.

@skjnldsv skjnldsv merged commit 6329027 into master Sep 6, 2022
@skjnldsv skjnldsv deleted the enh/empty_vue branch September 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants