fix: Avoid failing on public dav URLs #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
requested review from
luka-nextcloud,
grnd-alt and
elzody
as code owners
juliusknorr
commented
Jan 2, 2025
| @@ -88,8 +88,6 @@ public function __construct( | |||
| $this->changeHelper = $changeHelper; | |||
| $this->activityManager = $activityManager; | |||
| $this->eventDispatcher = $eventDispatcher; | |||
|
|
|||
| $this->assignmentServiceValidator->check(compact('userId')); | |||
There was a problem hiding this comment.
This is fine as it is checked in the controller methods
luka-nextcloud
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the dav plugins are now also called on public share links, so this changes ensure that we do not throw errors as deck is not expecting its classes to be initialized without a user session.