Language: Shouting at user (!) removed #474
Conversation
|
@comradekingu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @raghunayyar and @tcitworld to be potential reviewers. |
|
It shows an error and we can't proceed when the user doesn't select a calendar. I don't see why an exclamation mark is wrong here. |
|
exclamation mark is frankly is not shouting. |
|
More seriously though, let's ask @jancborchardt or someone else to write something on phrasing in Nextcloud so we can refer to it. |
|
@georgehrke While I agree, that is not English. Since this is difficult, or requires additional wording, doing away with the "!" in favour of "." is an easy fix that can not at the very least be mistaken for anything else. |
|
The removal of the exclamation mark is good. :) Much more friendly. Not sure about changing »select« to »pick« though, because we use »select« everywhere else I think. |
|
@jancborchardt I imagined it to be a pick-and-done type of thing, rather than a select-between-many-and-do-something-else ordeal. |
|
@comradekingu ok, sounds good. Can you fix the two other occurences @georgehrke listed? |
|
@comradekingu Can you please squash the commits? |
| error = true; | ||
| } | ||
| if (!$scope.properties.checkDtStartBeforeDtEnd()) { | ||
| OC.Notification.showTemporary(t('calendar', 'The event ends before it starts!')); | ||
| OC.Notification.showTemporary(t('calendar', 'The event can not end before it starts.')); |
There was a problem hiding this comment.
What about may not end?
There was a problem hiding this comment.
I think it is a, while polite, way that makes it harder for people whom are not English to understand it.
Entertain the idea that "may not" could mean it is not 100% clear cut that the event ends before it starts. The event may not, … As in maybe. And yes, into context you could derive that this is not the intention, but it makes it possible to get into that sort of thinking.
Word for word, you are better off 3 and 4 words in with "can not".
There was a problem hiding this comment.
Yeah, "can not" seems better.
Even better would be though if the dates would always be adjusted automatically. When you adjust the start date beyond the end date, move the end date accordingly. And vice versa, when you modify the end date to be before the start date, adjist the start date. This message should never ever need to be shown. :)
There was a problem hiding this comment.
If it just lights up in red whenever it is not a valid span, it would be more intuitive.
There was a problem hiding this comment.
Yeah, "can not" seems better.
Hm. ok. I still think @comradekingu underestimates our translators ;)
When you adjust the start date beyond the end date, move the end date accordingly.
The end date is currently always adjusted when changing the start date :)
So about changing the end date?
What if a user changes the end to something before start?
- change the start time to the end time?
or - change the start time to the end time minus one hour?
There was a problem hiding this comment.
Yep, change the start time to end time minus one hour. Or for a full-day event of course make it a one-day event.
There was a problem hiding this comment.
Okay :)
Will create an issue for it
| error = true; | ||
| } | ||
| if ($scope.calendar === null || typeof $scope.calendar === 'undefined') { | ||
| OC.Notification.showTemporary(t('calendar', 'Please select a calendar!')); | ||
| OC.Notification.showTemporary(t('calendar', 'Please pick a calendar.')); |
Update editorcontroller.js Consistent use of inside-voice to talk to user. Impossible event line changed to make it not sound anecdotal without the exclamation. Select instead of pick Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
comradekingu-patch-3
branch
from
32c6120 to
6659214
Compare
|
Let's merge after the tests passed |
No description provided.