Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pre-event signals for branch actions #129

Closed
jeremystretch opened this issue Sep 16, 2024 · 0 comments · Fixed by #130
Closed

Implement pre-event signals for branch actions #129

jeremystretch opened this issue Sep 16, 2024 · 0 comments · Fixed by #130
Assignees
Labels
type: feature A new feature or functionality

Comments

@jeremystretch
Copy link
Contributor

Plugin Version

v0.5.0

Proposed functionality

We currently have signals which fire at the end of a branch event (e.g. syncing or merging a branch). This FR proposes adding their pre-event complements, and renaming the existing signals to the form post_$action:

Pre-event signals

  • pre_provision
  • pre_deprovision
  • pre_sync
  • pre_merge
  • pre_revert

Post-event signals

  • branch_provisioned -> post_provision
  • branch_deprovisioned -> post_deprovision
  • branch_synced -> post_sync
  • branch_merged -> post_merge
  • branch_reverted -> post_revert

Use case

This will allow integrations to hook into the plugin both before and after branch events take place.

External dependencies

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant