Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by MAC address crashes "interfaces" tab view... #18447

Closed
christophenouvel opened this issue Jan 21, 2025 · 1 comment · Fixed by #18450
Closed

Sort by MAC address crashes "interfaces" tab view... #18447

christophenouvel opened this issue Jan 21, 2025 · 1 comment · Fixed by #18450
Assignees
@DanSheps
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@christophenouvel
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.2.2

Python Version

3.11

Steps to Reproduce

  1. Once logged in, clic "virtualization",
  2. clic "Virtual machines"
  3. clic a VM name which owns more than one interface (in order to be able to sort)
  4. clic "interfaces"
  5. clic to sort by "mac address".
    It's dead, you can not come back to ani "interfaces" tab anymore 👍

Expected Behavior

View "interfaces" tab like before MAC ADDRESS became an object.

Observed Behavior

Server Error

There was a problem with your request. Please contact an administrator.

The complete exception is provided below:

<class 'django.core.exceptions.FieldError'>

Cannot resolve keyword 'mac_address' into field. Choices are: _name, bookmarks, bridge, bridge_id, bridge_interfaces, child_interfaces, created, custom_field_data, description, enabled, fhrp_group_assignments, id, ip_addresses, journal_entries, l2vpn_terminations, last_updated, mac_addresses, mode, mtu, name, parent, parent_id, primary_mac_address, primary_mac_address_id, qinq_svlan, qinq_svlan_id, subscriptions, tagged_items, tagged_vlans, tags, tunnel_terminations, untagged_vlan, untagged_vlan_id, virtual_machine, virtual_machine_id, vlan_translation_policy, vlan_translation_policy_id, vrf, vrf_id

Python version: 3.11.2
NetBox version: 4.2.2
Plugins: None installed

If further assistance is required, please post to the NetBox discussion forum on GitHub.
Home Page
@christophenouvel christophenouvel added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jan 21, 2025
@christophenouvel christophenouvel changed the title Sort by MAC address cashes "interface" tab view... Sort by MAC address cashes "interfaces" tab view... Jan 21, 2025
@christophenouvel christophenouvel changed the title Sort by MAC address cashes "interfaces" tab view... Sort by MAC address crashes "interfaces" tab view... Jan 21, 2025
@christophenouvel christophenouvel marked this as a duplicate of #18446 Jan 21, 2025
@bctiemann
Copy link
Contributor

Also happens on VMInterface list view

@DanSheps DanSheps self-assigned this Jan 21, 2025
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available complexity: medium Requires a substantial but not unusual amount of effort to implement severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs triage This issue is awaiting triage by a maintainer severity: low Does not significantly disrupt application functionality, or a workaround is available complexity: medium Requires a substantial but not unusual amount of effort to implement labels Jan 21, 2025
@bctiemann bctiemann added severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: accepted This issue has been accepted for implementation labels Jan 21, 2025
@DanSheps DanSheps mentioned this issue Jan 21, 2025
Merged
@bctiemann bctiemann mentioned this issue Jan 22, 2025
Closed
@DanSheps DanSheps added status: accepted This issue has been accepted for implementation and removed severity: low Does not significantly disrupt application functionality, or a workaround is available labels Jan 24, 2025
bctiemann added a commit that referenced this issue Jan 24, 2025
@bctiemann
Merge pull request #18450 from netbox-community/18447-fix-legacy-maca…
a816889 
…ddress-sorting

Fixes: #18447 - Fix sorting by `mac_address` field
bctiemann pushed a commit that referenced this issue Jan 28, 2025
@DanSheps @bctiemann
Fixes: #18447 - Fix sorting by mac_address field
51544b2 
* Disable sorting by `mac_address` for legacy `mac_address` field for Device and VM Interfaces
* Ensure `primary_mac_address` field is included in field list for Device and VM Interfaces
bctiemann pushed a commit that referenced this issue Jan 29, 2025
@DanSheps @bctiemann
Fixes: #18447 - Fix sorting by mac_address field
b8370c5 
* Disable sorting by `mac_address` for legacy `mac_address` field for Device and VM Interfaces
* Ensure `primary_mac_address` field is included in field list for Device and VM Interfaces
@bctiemann bctiemann mentioned this issue Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanSheps DanSheps

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #18447 - Fix sorting by mac_address field netbox-community/netbox
3 participants
@bctiemann @DanSheps @christophenouvel