-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.4.0 #582
Merged
Version 1.4.0 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the container is started as root the default was to drop privileges to "unit:unit". This caused some problems with temporary files. Now the privileges are drop to "101:0". When the container is started as a normal user unit prints a warning that changing the user and group is not possible. This warning is safe to ignore.
Adds an additional container in which the new "housekeeping" command from Netbox v3.0.0 is run.
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
Update dependency google-crc32c to v1.1.5
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
Check if remote branch exists before checkout
Print last line of django db connection error while waiting for db to start
Added container for Netbox housekeeping command
Drops privileges to user 101 and group 0
cimnine
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:-
New Behavior
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
Changes to the Wiki
Proposed Release Note Entry
Noteworthy Changes
Drops privileges to user 101 and group 0 #546
This fixes some of the permission errors when the container is started as root.
Added container for Netbox housekeeping command #571
Netbox version 3.0.x has a new housekeeping command that should be run periodically. This adds an additional container in which this command is run every 24 hours. The interval can be changed with a new environment variable:
HOUSEKEEPING_INTERVAL
Print last line of django db connection error while waiting for the database to start #565
Display an error message when the database fails to start and a hint on how to print the complete error
Check if remote branch exists before checkout #579
The build script checks if the Netbox branch / tags exists before starting the build process. With this change we can now print a useful error message if a branch / tag is missing instead of a Git error.
Use
tini
as entrypointAll containers use
tini
as entrypint for correct handling of PID1 responsibilities.Compatibility
This version of Netbox Docker is only compatible with Netbox v3.0.x. For older versions, use a previous release of Netbox Docker.
Known Issues
There are no confirmed issues at the time of writing this. See the issues labelled bug in our issues section.
Sponsoring
Consider buying the maintainers of this project a beer or drink:
Double Check
develop
branch.