Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/docker port issue #538

Merged

Conversation

dmetzler1988
Copy link
Contributor

New Behavior

Fixed error with port on startup with latest Docker version (3.5.1 (66090)).
Only removed the empty port declaration in docker-compose.yml file.

Contrast to Current Behavior

Currently with the latest Docker version (3.5.1 (66090)) for MacOS the container can't be started because Docker doesn't allow the empty port declaration in docker-compose.yml.

It will throw an error which says:

services.netbox-worker.ports must be a list

Proposed Release Note Entry

Fixed port issue with latest Docker version.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine cimnine requested a review from tobiasge August 2, 2021 12:06
@cimnine cimnine added the bug This issue describes a confirmed bug. label Aug 2, 2021
@cimnine cimnine self-assigned this Aug 2, 2021
@cimnine cimnine added this to the next milestone Aug 2, 2021
@tobiasge tobiasge merged commit a0a32b9 into netbox-community:develop Sep 3, 2021
@tobiasge tobiasge mentioned this pull request Sep 3, 2021
3 tasks
@dmetzler1988 dmetzler1988 deleted the bugfix/docker-port-issue branch September 9, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants