Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nginx unit to 1.34.1 #1372

Merged

Conversation

mvanwilligen-prox
Copy link
Contributor

This fixes the OTel bug in nginx unit 1.34.0.

Related Issue: N/A

New Behavior

This PR updates NGINX Unit to version 1.34.1, which resolves a known issue affecting OpenTelemetry (OTel).

Our internal tooling relies on sending OTel headers, including to our NetBox instance. However, version 1.34.0 of NGINX Unit contains a bug that causes the container to crash when processing these headers.

Reference to Nginx unit 1.34.1 release notes: https://unit.nginx.org/news/2025/unit-1.34.1-released/

Contrast to Current Behavior

Nginx unit is updated from 1.34.0 to 1.34.1.

Discussion: Benefits and Drawbacks

This is a bugfix for Nginx unit that will support OTel headers also if it's not configured in Nginx unit. I think the community will benefit from this if someone is also using OTel in his tooling but does not 'disable' it for connections towards Netbox.

Changes to the Wiki

N/A

Proposed Release Note Entry

Update Nginx unit to 1.34.1

Double Check

  • [x ] I have read the comments and followed the PR template.
  • [ x] I have explained my PR according to the information in the comments.
  • [x ] My PR targets the develop branch.

This fixes the OTel bug in nginx unit 1.34.0.

Signed-off-by: Mathijs van Willigen <mavanwilligen@proxsys.nl>
@mvanwilligen-prox mvanwilligen-prox changed the base branch from release to develop January 13, 2025 09:47
@RangerRick
Copy link
Contributor

FYI, I ran into SIG11s in NetBox Enterprise as well when certain payloads hit with unit 1.34.0. Updating to 1.34.1 fixed it. upstream fix is here

@tobiasge
Copy link
Member

Tested locally.

@tobiasge tobiasge merged commit a48b86b into netbox-community:develop Jan 16, 2025
@tobiasge tobiasge mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants