Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websockets): include exception cause to associate error with req #14184

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Includes the cause attribute when emitting the exception message. This allows the error to be associated with the request that caused the exception.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 21, 2024
@kamilmysliwiec kamilmysliwiec changed the base branch from feat/intrinsic-exception to 11.0.0 November 21, 2024 09:35
@kamilmysliwiec kamilmysliwiec changed the base branch from 11.0.0 to feat/intrinsic-exception November 21, 2024 09:38
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 67accd4b-d6fe-4768-bd81-f529b1cf3559

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.138%

Totals Coverage Status
Change from base Build 0437aad1-7980-44fc-9973-959c535010f9: 0.03%
Covered Lines: 6983
Relevant Lines: 7747

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec changed the base branch from feat/intrinsic-exception to 11.0.0 November 22, 2024 10:32
@kamilmysliwiec kamilmysliwiec merged commit 43cf572 into 11.0.0 Nov 22, 2024
3 checks passed
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 22, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants