Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of H1 headings and ToCs #142

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

Usage of H1 headings is not recommended therefore this commit removes them. Table of content was added to some of the pages, but Docsy generates automatically a ToC to the left side of the page. Manual maintenance of ToCs is not needed.

Usage of H1 headings is not reccomended [1] therefore this commit removes them.
Table of content was added to some of the pages, but Docsy generates automaticaly a
ToC to the left side of the page. Manual maintanance of ToCs is not needed.

[1]: google/docsy#2039

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@nephio-prow nephio-prow bot requested review from efiacor and s3wong June 19, 2024 08:52
@CsatariGergely
Copy link
Contributor Author

/assign @liamfallon @efiacor

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 3969b50
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66729c4a481fe70008dc283c
😎 Deploy Preview https://deploy-preview-142--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jun 21, 2024
Copy link
Contributor

nephio-prow bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 21, 2024
@nephio-prow nephio-prow bot merged commit 2b75bed into nephio-project:main Jun 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants