Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compute_tools and compute_api to edition 2024 #10983

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Feb 26, 2025

Updates compute_tools and compute_api crates to edition 2024. We like to stay on the latest edition if possible. There is no functional changes, however some code changes had to be done to accommodate the edition's breaking changes.

The PR has three commits:

  • the first commit updates the named crates to edition 2024 and appeases cargo clippy by changing code.
  • the second commit performs a cargo fmt that does some minor changes (not many)
  • the third commit performs a cargo fmt with nightly options to reorder imports as a one-time thing. it's completely optional, but I offer it here for the compute team to review it.

I'd like to hear opinions about the third commit, if it's wanted and felt worth the diff or not. I think most attention should be put onto the first commit.

Part of #10918

@arpad-m arpad-m requested review from a team as code owners February 26, 2025 00:59
@arpad-m arpad-m mentioned this pull request Feb 26, 2025
7 tasks
Copy link

github-actions bot commented Feb 26, 2025

7755 tests run: 7376 passed, 0 failed, 379 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 32.8% (8635 of 26357 functions)
  • lines: 48.6% (73089 of 150408 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ddaa05e at 2025-02-26T12:57:32.962Z :recycle:

@hlinnaka
Copy link
Contributor

  • the third commit performs a cargo fmt with nightly options to reorder imports as a one-time thing. it's completely optional, but I offer it here for the compute team to review it.

I'd like to hear opinions about the third commit, if it's wanted and felt worth the diff or not. I think most attention should be put onto the first commit.

I like it.

cargo +nightly fmt -p compute_tools -p compute_api -- -l --config imports_granularity=Module,group_imports=StdExternalCrate,reorder_imports=true
@arpad-m arpad-m force-pushed the arpad/edition_2024_compute branch from 3385f9b to ddaa05e Compare February 26, 2025 11:28
@arpad-m arpad-m added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit f94286f Feb 26, 2025
90 checks passed
@arpad-m arpad-m deleted the arpad/edition_2024_compute branch February 26, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants