Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_ctl: Add more detailed tracing spans to startup subroutines #10979

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

hlinnaka
Copy link
Contributor

In local dev environment, these steps take around 100 ms, and they are in the critical path of a compute startup on a compute pool hit. I don't know if it's like that in production, but as first step, add tracing spans to the functions so that they can be measured more easily.

@hlinnaka hlinnaka requested a review from a team as a code owner February 25, 2025 17:56
Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Matthias' comments.

Copy link

github-actions bot commented Feb 25, 2025

7755 tests run: 7376 passed, 0 failed, 379 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 32.8% (8637 of 26357 functions)
  • lines: 48.6% (73112 of 150406 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
323e237 at 2025-02-26T09:29:05.505Z :recycle:

In local dev environment, these steps take around 100 ms, and they are
in the critical path of a compute startup on a compute pool hit. I
don't know if it's like that in production, but as first step, add
tracing spans to the functions so that they can be measured more
easily.
@hlinnaka hlinnaka force-pushed the heikki/add-spans-for-swap-and-quota branch from 08438ad to 323e237 Compare February 26, 2025 08:24
@hlinnaka hlinnaka changed the title compute_ctl: Add instrumentation to resizing swap and setting disk quota compute_ctl: Add more detailed tracing spans to startup subroutines Feb 26, 2025
@hlinnaka
Copy link
Contributor Author

also added this check_safekeepers_synced function

@hlinnaka
Copy link
Contributor Author

Here's a screenshot from local jaeger UI with this PR and PR #10971:

image

The "resize_swap", "set_disk_quota", and "check_safekeepers_synced" spans are the new ones added by this PR.

@hlinnaka hlinnaka added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 43b109a Feb 26, 2025
90 checks passed
@hlinnaka hlinnaka deleted the heikki/add-spans-for-swap-and-quota branch February 26, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants