Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremenet getpage histogram in prefetch_lookup #10965

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

knizhnik
Copy link
Contributor

Problem

PR #10442 added prefetch_lookup function.
It changed handling of getpage requests in compute.

Before:

  1. Lookup in LFC (return if found)

  2. Register prefetch buffer

  3. Wait prefetch result (increment getpage_hist)
    Now:

  4. Lookup prefetch ring (return if prefetch request is already completed)

  5. Lookup in LFC (return if found)

  6. Register prefetch buffer

  7. Wait prefetch result (increment getpage_hist)

So if prefetch result is already available, then get page histogram is not incremented.
It case failure of some test_throughtput benchmarks:
https://neondb.slack.com/archives/C033RQ5SPDH/p1740425527249499

Summary of changes

Increment getpage histogram in prefetch_lookup

@knizhnik knizhnik requested review from a team as code owners February 25, 2025 06:16
Copy link

If this PR added a GUC in the Postgres fork or neon extension,
please regenerate the Postgres settings in the cloud repo:

make NEON_WORKDIR=path/to/neon/checkout \
  -C goapp/internal/shareddomain/postgres generate

If you're an external contributor, a Neon employee will assist in
making sure this step is done.

Copy link

github-actions bot commented Feb 25, 2025

7711 tests run: 7335 passed, 0 failed, 376 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.8% (8631 of 26298 functions)
  • lines: 48.6% (72630 of 149426 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1ccb40b at 2025-02-25T08:39:54.376Z :recycle:

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skyzh skyzh added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit dc975d5 Feb 25, 2025
94 checks passed
@skyzh skyzh deleted the inc_getpage_hist_in_prefetch_lookup branch February 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants