Incremenet getpage histogram in prefetch_lookup #10965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #10442 added prefetch_lookup function.
It changed handling of getpage requests in compute.
Before:
Lookup in LFC (return if found)
Register prefetch buffer
Wait prefetch result (increment getpage_hist)
Now:
Lookup prefetch ring (return if prefetch request is already completed)
Lookup in LFC (return if found)
Register prefetch buffer
Wait prefetch result (increment getpage_hist)
So if prefetch result is already available, then get page histogram is not incremented.
It case failure of some test_throughtput benchmarks:
https://neondb.slack.com/archives/C033RQ5SPDH/p1740425527249499
Summary of changes
Increment getpage histogram in
prefetch_lookup