feat(storcon): chaos injection of force exit #10934
Merged
+92
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi Z <chi@neon.tech>
|
Seems reasonable (I guess this was easier than maintaining external cronjob?) -- let's make sure devprod are aligned on the time of day to do this + make it CLI-configurable. |
|
Yes, cronjob needs some complex permission setup in kubernetes to allow a job to manipulate the cluster and I think it will take longer than this approach :( |
7601 tests run: 7225 passed, 0 failed, 376 skipped (full report)Flaky tests (3)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
384493f at 2025-02-24T05:44:54.692Z :recycle: |
skyzh
changed the title
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/storcon-chaos
branch
from
d9d1b6f to
2608bc2
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
|
ready for review :) The next step: discuss the injection time, and add support to helm-charts + PR to the infra repo |
jcsp
approved these changes
Feb 24, 2025
This was referenced Feb 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
## Problem Somehow the previous patch loses the loop in the chaos injector function so everything will only run once. #10934 ## Summary of changes Add back the loop. Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
close /~https://github.com/neondatabase/cloud/issues/24485
Summary of changes
This patch adds a new chaos injection mode for the storcon. The chaos injector reads the crontab and exits immediately at the configured time.