Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make Workload more determinstic #10741

Merged
merged 8 commits into from
Feb 12, 2025
Merged

tests: make Workload more determinstic #10741

merged 8 commits into from
Feb 12, 2025

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Feb 10, 2025

Problem

Previously, Workload was reconfiguring the compute before each run of writes, which was meant to be a no-op when nothing changed, but was actually writing extra data due to an issue being fixed in #10696.

The row counts in tests were too low in some cases, these tests were only working because of those extra writes that shouldn't have been happening, and moreover were relying on checkpoints happening.

Summary of changes

  • Only reconfigure compute if the attached pageserver actually changed. If pageserver is set to None, that means controller is managing everything, so never reconfigure compute.
  • Update tests that wrote too few rows.

Copy link

github-actions bot commented Feb 10, 2025

7436 tests run: 7056 passed, 0 failed, 380 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 33.2% (8583 of 25872 functions)
  • lines: 49.1% (72278 of 147344 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c765718 at 2025-02-12T11:23:00.790Z :recycle:

@jcsp jcsp force-pushed the jcsp/tests-workload branch from 5e6bf2d to fe80ddc Compare February 11, 2025 13:11
@jcsp jcsp requested a review from ololobus February 11, 2025 13:11
@jcsp jcsp marked this pull request as ready for review February 11, 2025 18:08
@jcsp jcsp enabled auto-merge February 11, 2025 18:08
@jcsp
Copy link
Contributor Author

jcsp commented Feb 12, 2025

Failures due to stuck tests: {'test_sharding_split_failures[release-pg15-failure10]', 'test_sharding_split_failures[release-pg15-failure5]'}

Different runs have various different permutations of sharding_split_failures getting stuck.

@jcsp jcsp added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 9989d8b Feb 12, 2025
86 checks passed
@jcsp jcsp deleted the jcsp/tests-workload branch February 12, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants