Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSO parameters being lost on browser redirect #1009

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

alfredorubin96
Copy link
Collaborator

when redirecting we were losing context of the UrlParams defined by the user

@alfredorubin96 alfredorubin96 added the 2.4.10 For this release label Nov 29, 2024
@@ -491,6 +494,7 @@ export const loadApplicationConfigThunk = () => async (dispatch: any, getState:
dispatch(setAboutModalOpen(false));
dispatch(setConnected(false));
dispatch(setWelcomeScreenOpen(false));
console.log('EDDAJE');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this console.log

Copy link

sonarqubecloud bot commented Dec 2, 2024

@bastienhubert bastienhubert added the bug Something isn't working label Jan 28, 2025
@alfredorubin96 alfredorubin96 added the priority important request/feature label Jan 29, 2025
@alfredorubin96 alfredorubin96 merged commit f3ae774 into develop Feb 10, 2025
2 checks passed
@alfredorubin96 alfredorubin96 deleted the fix/sso-standalone-params branch February 10, 2025 16:08
@nielsdejong nielsdejong changed the title fixing strange param behaviour with sso Fix SSO parameters being lost on browser redirect Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.10 For this release bug Something isn't working priority important request/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants