improve parse method in neo-cli #3204

chenzhitong · 2024-04-24T03:30:02Z

I didn't add the Mnemonic conversion because it would require bringing in other NuGet packages. For Mnemonic conversion you can use the web version of the conversion tool https://neo.org/converter/index

chenzhitong · 2024-04-25T03:00:39Z

@Jim8y @shargon please review

Jim8y · 2024-04-25T03:03:16Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        /// <returns>Returns null when the string does not represent a private key; otherwise
+        /// returns the string that represents the converted public key.
+        /// </returns>
+        public static string? PrivateKeyToPublicKey(string wif)


wif to pubkey？

wif to pubkey？

Yeah. What's the problem?

nothing，just thinking maybe you can make it both support wif and privatkey @shargon

It worries me that people use a private key so openly, why not create a wallet?

src/Neo.CLI/CLI/MainService.Tools.cs

shargon · 2024-04-25T10:31:27Z

src/Neo.CLI/CLI/MainService.Tools.cs

+            //Initialize all OpCodes
+            var OperandSizePrefixTable = new int[256];
+            var OperandSizeTable = new int[256];
+            foreach (FieldInfo field in typeof(OpCode).GetFields(BindingFlags.Public | BindingFlags.Static))


Why not use Script and GetInstruction?

Yes use Script class or something like this

byte[] data = []; foreach (var d in data) { Console.WriteLine(Enum.GetName((OpCode)d)); }

AnnaShaleva · 2024-04-25T18:01:06Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        private string? AddressToScripthashLE(string address)
+        {
+            try
+            {
+                var bigEndScript = address.ToScriptHash(NeoSystem.Settings.AddressVersion);
+
+                return bigEndScript.ToArray().ToHexString();
+            }
+            catch
+            {
+                return null;
+            }
+        }


Could you please add the following compatibility test for this API: convert address NRQJbjKWgcLX214Kbx6PDH2CHJdqbsSi4Q to LE script hash. I'd like to ensure that NeoGo has the same LE/BE conversion result:

anna@kiwi:~/Documents/GitProjects/nspcc-dev/neo-go$ ./bin/neo-go util convert NRQJbjKWgcLX214Kbx6PDH2CHJdqbsSi4Q Address to BE ScriptHash 3c347b368199840085f7d92704a14becd578fa3d Address to LE ScriptHash 3dfa78d5ec4ba10427d9f78500849981367b343c Address to Base64 (BE) PDR7NoGZhACF99knBKFL7NV4+j0= Address to Base64 (LE) Pfp41exLoQQn2feFAISZgTZ7NDw= String to Hex 4e52514a626a4b5767634c583231344b6278365044483243484a6471627353693451 String to Base64 TlJRSmJqS1dnY0xYMjE0S2J4NlBESDJDSEpkcWJzU2k0UQ==

public static UInt160? TryParseUInt160(string? value) { if (string.IsNullOrEmpty(value)) return default; if (UInt160.TryParse(value, out var result)) return result; return UInt160.Zero; }

AnnaShaleva · 2024-04-25T18:05:43Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        public string? BigEndianToLittleEndian(string hex)
+        {
+            hex = hex.ToLower();
+            if (!new Regex("^0x([0-9a-f]{2})+$").IsMatch(hex)) return null;


Can we make 0x prefix optional?

Just check and remove it

Already modified

AnnaShaleva · 2024-04-25T18:12:35Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                    if (op.ToString().StartsWith("PUSHINT"))
+                    {
+                        result.Add($"{op} {new BigInteger(operand)}");
+                    }
+                    else if (op == OpCode.SYSCALL)
+                    {
+                        result.Add($"{op} {dic[BitConverter.ToUInt32(operand)]}");
+                    }
+                    else
+                    {
+                        result.Add($"{op} {operand.ToHexString()}");
+                    }


We may extend the list of available formatters, take a look at the /~https://github.com/nspcc-dev/neo-go/blob/198af7f3aef039995b8f8cacefefb3a807b41ff3/pkg/vm/vm.go#L184-L230

cschuchardt88

Dont use RegEx is so expensive and cost way to much CPU and can hang forever.
Your naming convention. Change all methods to the proper names. To many for me to change for you; in a review. If you want I can change for you in Visual Studio; just would need access to your repo.

cschuchardt88 · 2024-04-25T22:11:55Z

src/Neo.CLI/CLI/MainService.Tools.cs

            var parseFunctions = new Dictionary<string, Func<string, string?>>()
            {
-                { "Address to ScriptHash", AddressToScripthash },
+                { "Address to ScriptHash (big-endian)", AddressToScripthash },


Can we use Attribute class for the function description?

Good idea, I'll do it.

Already modified

cschuchardt88 · 2024-04-25T22:18:05Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        /// </returns>
+        private string? NumberToHexToString(string input)
+        {
+            if (!new Regex("^\\d+$").IsMatch(input) || input.StartsWith('0'))


TryCatch is faster and cheaper for checking HexString encoding. Just TryCatch Convert.ToHexString and look for FormatException

Already modified

cschuchardt88 · 2024-04-25T22:19:25Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        /// <returns>Correct Base64 string</returns>
+        public static string Base64Fixed(string str)
+        {
+            MatchCollection mc = Regex.Matches(str, @"\\u([\w]{2})([\w]{2})", RegexOptions.Compiled | RegexOptions.IgnoreCase);


TryCatch is faster and cheaper for checking Base64 encoding. Just TryCatch Convert.FromBase64String and look for FormatException

cschuchardt88 · 2024-04-25T22:21:17Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                    result.Add($"{op}");
+                }
+            }
+            return "\r\n" + string.Join("\r\n", result.ToArray());


Use Environment.NewLine we do support different Operating Systems.

Already modified

chenzhitong · 2024-04-26T02:09:40Z

Dont use RegEx is so expensive and cost way to much CPU and can hang forever.

Your naming convention. Change all methods to the proper names. To many for me to change for you; in a review. If you want I can change for you in Visual Studio; just would need access to your repo.

I invited you. Thanks.
/~https://github.com/chenzhitong/neo/invitations

shargon · 2024-04-30T08:51:03Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        private string? BigEndianToLittleEndian(string hex)
+        {
+            bool hasHexPrefix = hex.StartsWith("0x", StringComparison.InvariantCultureIgnoreCase);
+            hex = hex[2..];


this will throw an exception if the input is "a"

shargon · 2024-04-30T08:51:37Z

src/Neo.CLI/CLI/MainService.Tools.cs


 namespace Neo.CLI
 {
+    public class ParseFunctionAttribute : Attribute


One file per class

Unless it has Interface with it.

shargon · 2024-04-30T08:52:02Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        [ParseFunction("Public Key to Address")]
+        private string? PublicKeyToAddress(string pubKey)
+        {
+            bool IsValidPubKey(string pubKey)


Move method outside

cschuchardt88 · 2024-05-01T03:02:12Z

src/Neo.CLI/CLI/MainService.Tools.cs

+            if (pubKey.Length != 66) return false;
+            if (pubKey[0] != '0') return false;
+            if (pubKey[1] != '2' && pubKey[1] != '3') return false;
+
+            for (var i = 2; i < pubKey.Length; i++)
+            {
+                var c = pubKey[i];
+                if (!((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') || (c >= 'A' && c <= 'F')))
+                {
+                    return false;
+                }
+            }
+
+            return true;


Suggested change

if (pubKey.Length != 66) return false;

if (pubKey[0] != '0') return false;

if (pubKey[1] != '2' && pubKey[1] != '3') return false;

for (var i = 2; i < pubKey.Length; i++)

{

var c = pubKey[i];

if (!((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') || (c >= 'A' && c <= 'F')))

{

return false;

}

}

return true;

return ECPoint.TryParse(pubkey, ECCurve.Secp256r1, out _);

public keys can be many lengths and prefixes. Look at Neo.Cryptography.ECC.ECPoint class in method TryParse, Parse, DecodePoint or FromBytes

Already removed IsValidPubKey method

cschuchardt88

Please remove all the hex methods in the file. No need for it. DotNet has Convert.ToHexString or Convert.FromHexString built-in.

cschuchardt88 · 2024-05-01T18:14:11Z

src/Neo.CLI/CLI/MainService.Tools.cs

-        /// string or when the converted string is not printable; otherwise, returns
-        /// the string represented by the hexadecimal value
-        /// </returns>
+        [ParseFunction("Hex String to String")]
        private string? HexToString(string hexString)
        {
            try


This can be replaced with Convert.ToHexString

Already removed HexToString StringToHex NumberToHexToString HexToNumber Base64ToHexString HexScriptsToOpCode method

cschuchardt88 · 2024-05-01T18:18:55Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                if (!IsHex(hex)) return null;
+                return "0x" + hex.HexToBytes().Reverse().ToArray().ToHexString(); ;


Suggested change

if (!IsHex(hex)) return null;

return "0x" + hex.HexToBytes().Reverse().ToArray().ToHexString(); ;

Convert.FromHexString(hex); // check for is Hex

var bytes = System.Text.Encoding.UTF8.GetBytes(hex);

return "0x" + Convert.ToHexString([.. bytes.Reverse()]).ToLower();

This will output an uppercase string

There I changed to LowerCase.

cschuchardt88 · 2024-05-01T18:23:47Z

src/Neo.CLI/CLI/MainService.Tools.cs

+            bool hasHexPrefix = hex.StartsWith("0x", StringComparison.InvariantCultureIgnoreCase);
+            hex = hasHexPrefix ? hex[2..] : hex;
+            if (!hasHexPrefix || !IsHex(hex)) return null;
+            return hex.HexToBytes().Reverse().ToArray().ToHexString();


Suggested change

bool hasHexPrefix = hex.StartsWith("0x", StringComparison.InvariantCultureIgnoreCase);

hex = hasHexPrefix ? hex[2..] : hex;

if (!hasHexPrefix || !IsHex(hex)) return null;

return hex.HexToBytes().Reverse().ToArray().ToHexString();

Convert.FromHexString(hex); // Check for hex

var bytes = System.Text.Encoding.UTF8.GetBytes(hex);

return Convert.ToHexString([.. bytes.Reverse()]);

It will crash when parse "0x3ff68d232a60f23a5805b8c40f7e61747f6f61ce"

wrap in TryCatch

cschuchardt88 · 2024-05-01T18:30:55Z

src/Neo.CLI/CLI/MainService.Tools.cs

-        /// </returns>
+        /// <param name="str">Base64 strings containing unicode</param>
+        /// <returns>Correct Base64 string</returns>
+        public string Base64Fixed(string str)


I believe Console.OutputEncoding = Utility.StrictUTF8; will fix this problem.

The purpose of this one is to handle the output of other wallets or SDKs that have Base64 with Unicode escaped characters in them

cschuchardt88 · 2024-05-01T18:32:25Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                var bigEndScript = address.ToScriptHash(NeoSystem.Settings.AddressVersion);
+
+                return bigEndScript.ToArray().ToHexString();


Suggested change

var bigEndScript = address.ToScriptHash(NeoSystem.Settings.AddressVersion);

return bigEndScript.ToArray().ToHexString();

return address.ToScriptHash(NeoSystem.Settings.AddressVersion);

This will output a result of type UInt160, not a string.

cschuchardt88 · 2024-05-01T18:34:04Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                var bytes = Convert.FromBase64String(base64.Trim());
+                return bytes.ToHexString();


Suggested change

var bytes = Convert.FromBase64String(base64.Trim());

return bytes.ToHexString();

var bytes = Convert.FromBase64String(base64.Trim());

return $"0x{Convert.ToHexString(bytes)}";

Already modified

cschuchardt88 · 2024-05-01T18:39:19Z

src/Neo.CLI/CLI/MainService.Tools.cs

+            if (!IsValidPubKey(pubKey)) return null;
+            return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(NeoSystem.Settings.AddressVersion);


Suggested change

if (!IsValidPubKey(pubKey)) return null;

return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(NeoSystem.Settings.AddressVersion);

if (ECPoint.TryParse(pubKey, ECCurve.Secp256r1, out var publicKey) == false)

return null;

return Contract.CreateSignatureContract(publicKey)

.ScriptHash

.ToAddress(NeoSystem.Settings.AddressVersion);

Already modified

cschuchardt88 · 2024-05-01T18:41:15Z

src/Neo.CLI/CLI/MainService.Tools.cs

+            {
+                var privateKey = Wallet.GetPrivateKeyFromWIF(wif);
+                var account = new KeyPair(privateKey);
+                return account.PublicKey.ToArray().ToHexString();


Suggested change

return account.PublicKey.ToArray().ToHexString();

return Convert.ToHexString(account.PublicKey.EncodePoint(true)).ToLower();

This will output an uppercase string

cschuchardt88 · 2024-05-01T18:52:36Z

src/Neo.CLI/CLI/MainService.Tools.cs

+                var pubKey = WIFToPublicKey(wif);
+                return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(0x35);


Suggested change

var pubKey = WIFToPublicKey(wif);

return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(0x35);

var privateKey = Wallet.GetPrivateKeyFromWIF(wif);

var account = new KeyPair(privateKey);

return account.PublicKeyHash.ToAddress(NeoSystem.Settings.AddressVersion);

These two results are not the same

oh sorry, but what's the 0x35 for?

…onverter

chenzhitong · 2024-05-09T09:27:31Z

Can this be merged?

cschuchardt88

Also please run dotnet format we have made changes the .editorconfig to re-run .github action tests.

cschuchardt88 · 2024-05-09T11:32:57Z

src/Neo.CLI/CLI/MainService.Tools.cs

+        private bool IsHex(string str) => str.Length % 2 == 0 && str.All(c => (c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') || (c >= 'A' && c <= 'F'));
+


This will always be false because of the prefix 0x having the x in it.

It is by design, only for hexstring without '0x'

dotnet format passed with no changes

cschuchardt88

😄

chenzhitong · 2024-05-10T03:18:49Z

Added ToLower() for LowerCase hexes.

Already modified, and ToHexString() is already lowercase.

chenzhitong · 2024-05-11T10:02:17Z

Can this be merged? @shargon @cschuchardt88 @Jim8y

cschuchardt88 · 2024-05-11T16:16:47Z

Need a minimum of two people to approve on a PR before you can merge it.

src/Neo.CLI/CLI/MainService.Tools.cs

vncoelho

LGTM but I need one week to test.
We are still investigating current release and adjusting our tools.

Jim8y · 2024-05-14T11:59:51Z

Let us wait until the 3.7 mainnet is online please.

vncoelho · 2024-05-14T14:05:50Z

I think that we should wait a little as @Jim8y emphasized.

…gins * 'latest-plugins' of github.com:Jim8y/neo: (21 commits) fix: custom plugins won't shown by command `plugins` (neo-project#3269) COVERALL: Improve maintenance and readbility of some variables (neo-project#3248) Update nuget (neo-project#3262) [**Part-2**] Neo module/master fixes (neo-project#3244) Fix `dotnet pack` error (neo-project#3266) Fix and Update devcontainer.json to use Dockerfile (neo-project#3259) Add optimization to template (neo-project#3247) Optimize plugin's models (neo-project#3246) fix CancelTransaction !signers.Any() (neo-project#3263) COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252) fix TraverseIterator count (neo-project#3261) Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245) [**Part-1**] `neo-module/master` (neo-project#3232) Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243) improve parse method in neo-cli (neo-project#3204) Fix neo-project#3239 (neo-project#3242) Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240) v3.7.4 (neo-project#3237) fix hardfork issues (neo-project#3234) Update src/Neo.CLI/CLI/MainService.Plugins.cs ... # Conflicts: # src/Neo.CLI/CLI/MainService.Plugins.cs

chenzhitong added 3 commits April 24, 2024 11:27

Update MainService.Tools.cs

e1d8e14

format

25b16f6

Update MainService.Tools.cs

0bcbcda

Jim8y reviewed Apr 25, 2024

View reviewed changes

shargon reviewed Apr 25, 2024

View reviewed changes

AnnaShaleva reviewed Apr 25, 2024

View reviewed changes

cschuchardt88 requested changes Apr 25, 2024

View reviewed changes

chenzhitong added 6 commits April 26, 2024 10:36

Update MainService.Tools.cs

0c36106

Update MainService.Tools.cs

43faa79

Update MainService.Tools.cs

4acbe95

Update MainService.Tools.cs

ecc7cbb

Update MainService.Tools.cs

9e6f07c

Update MainService.Tools.cs

ff3406d

shargon reviewed Apr 30, 2024

View reviewed changes

chenzhitong added 2 commits May 1, 2024 09:58

update

214f62b

Update MainService.Tools.cs

7b5c9e1

cschuchardt88 requested changes May 1, 2024

View reviewed changes

chenzhitong added 7 commits May 6, 2024 10:32

Update MainService.Tools.cs

7b9a17a

Merge branch 'master' into converter

75f4473

Update MainService.Tools.cs

b42fa7b

Merge branch 'converter' of /~https://github.com/chenzhitong/neo into c…

7d5c5ca

…onverter

Merge branch 'master' into converter

31c226f

format

90d10ef

Merge branch 'master' into converter

010f34b

cschuchardt88 requested changes May 9, 2024

View reviewed changes

Merge branch 'master' into converter

cd69789

cschuchardt88 previously approved these changes May 10, 2024

View reviewed changes

Merge branch 'master' into converter

fcc8cec

Jim8y previously approved these changes May 12, 2024

View reviewed changes

shargon added 2 commits May 13, 2024 08:07

Merge branch 'master' into converter

484f1e6

Review

250c8ea

shargon dismissed Jim8y’s stale review via 250c8ea May 13, 2024 15:26

shargon previously approved these changes May 13, 2024

View reviewed changes

shargon reviewed May 13, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Tools.cs Outdated Show resolved Hide resolved

fixedbug

6fdab35

chenzhitong dismissed shargon’s stale review via 6fdab35 May 14, 2024 08:03

Update MainService.Tools.cs

17141e4

shargon approved these changes May 14, 2024

View reviewed changes

vncoelho reviewed May 14, 2024

View reviewed changes

chenzhitong dismissed cschuchardt88’s stale review via 17141e4 May 15, 2024 12:37

shargon added Blocked This issue can't be worked at the moment Cosmetic Type - Changes that improve user experience without affecting current functionality. labels May 16, 2024

shargon and others added 3 commits May 16, 2024 01:42

Merge branch 'master' into converter

63e992a

Merge branch 'master' into converter

ef81c32

Merge branch 'master' into converter

4f6afbb

Jim8y approved these changes May 20, 2024

View reviewed changes

Merge branch 'master' into converter

f6e652e

shargon merged commit 8b687b6 into neo-project:master May 20, 2024
6 checks passed

This was referenced May 20, 2024

[**Part-1**] neo-module/master #3232

Merged

COVERALL: fix broken by changing report from lcov to cobertura #3252

Merged

		if (!IsHex(hex)) return null;
		return "0x" + hex.HexToBytes().Reverse().ToArray().ToHexString(); ;

-                if (!IsHex(hex)) return null;
-                return "0x" + hex.HexToBytes().Reverse().ToArray().ToHexString(); ;
+                Convert.FromHexString(hex); // check for is Hex
+                var bytes = System.Text.Encoding.UTF8.GetBytes(hex);
+                return "0x" + Convert.ToHexString([.. bytes.Reverse()]).ToLower();

		var bigEndScript = address.ToScriptHash(NeoSystem.Settings.AddressVersion);

		return bigEndScript.ToArray().ToHexString();

		var bytes = Convert.FromBase64String(base64.Trim());
		return bytes.ToHexString();

		if (!IsValidPubKey(pubKey)) return null;
		return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(NeoSystem.Settings.AddressVersion);

	return account.PublicKey.ToArray().ToHexString();
	return Convert.ToHexString(account.PublicKey.EncodePoint(true)).ToLower();

		var pubKey = WIFToPublicKey(wif);
		return Contract.CreateSignatureContract(ECPoint.Parse(pubKey, ECCurve.Secp256r1)).ScriptHash.ToAddress(0x35);

		private bool IsHex(string str) => str.Length % 2 == 0 && str.All(c => (c >= '0' && c <= '9') \|\| (c >= 'a' && c <= 'f') \|\| (c >= 'A' && c <= 'F'));

improve parse method in neo-cli #3204

improve parse method in neo-cli #3204

Conversation

chenzhitong commented Apr 24, 2024 • edited Loading

chenzhitong commented Apr 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jim8y Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 left a comment • edited Loading

Choose a reason for hiding this comment

cschuchardt88 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

cschuchardt88 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenzhitong commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 May 1, 2024 • edited Loading

Choose a reason for hiding this comment

cschuchardt88 May 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 May 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 May 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 May 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenzhitong commented May 9, 2024

cschuchardt88 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cschuchardt88 left a comment

Choose a reason for hiding this comment

chenzhitong commented May 10, 2024

chenzhitong commented May 11, 2024 • edited Loading

cschuchardt88 commented May 11, 2024

chenzhitong commented Apr 24, 2024 •

edited

Loading

Jim8y Apr 25, 2024 •

edited

Loading

cschuchardt88 Apr 25, 2024 •

edited

Loading

cschuchardt88 left a comment •

edited

Loading

cschuchardt88 Apr 25, 2024 •

edited

Loading

cschuchardt88 Apr 25, 2024 •

edited

Loading

cschuchardt88 Apr 25, 2024 •

edited

Loading

cschuchardt88 Apr 25, 2024 •

edited

Loading

cschuchardt88 May 1, 2024 •

edited

Loading

cschuchardt88 May 1, 2024 •

edited

Loading

cschuchardt88 May 1, 2024 •

edited

Loading

cschuchardt88 May 1, 2024 •

edited

Loading

cschuchardt88 May 1, 2024 •

edited

Loading

chenzhitong commented May 11, 2024 •

edited

Loading

vncoelho left a comment •

edited

Loading