-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Action Cache #1913
Conversation
a.NoError(err) | ||
a.NotEqual(0, th.Size) | ||
buf := &bytes.Buffer{} | ||
_, err = io.Copy(buf, mytar) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow tests need to be secured against DoS, what on earth
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Awaiting moby/moby#45935 to be fixed |
Codecov Report
@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 61.22% 62.13% +0.91%
==========================================
Files 46 52 +6
Lines 7141 8488 +1347
==========================================
+ Hits 4372 5274 +902
- Misses 2462 2795 +333
- Partials 307 419 +112
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's your chance to request / suggest changes, this has wide impact to act.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review cplee :).
@ChristopherHX this pull request has failed checks 🛠 |
This is a sample implementation of ActionCache.
See also #1912 and it's description for further links.