Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI changes for QHub #989

Merged
merged 4 commits into from
Jan 14, 2022
Merged

CI changes for QHub #989

merged 4 commits into from
Jan 14, 2022

Conversation

HarshCasper
Copy link
Contributor

@HarshCasper HarshCasper commented Jan 13, 2022 •
edited
Loading

Changes:

This PR:

  • Removes support for Python 3.6
  • Adds support for Python 3.9
  • Add concurrency variable to cancel old builds
  • Fix broken links on README.md

costrouc
costrouc approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Waiting for others to chime in before merging. I remember someone mentioning that there was a cloud provider that didn't support a newer version of python.

tonyfast
tonyfast suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@tonyfast tonyfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tonyfast tonyfast self-requested a review January 13, 2022 19:00
tonyfast
tonyfast approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@tonyfast tonyfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HarshCasper HarshCasper merged commit 2fc0a1b into main Jan 14, 2022
@HarshCasper HarshCasper deleted the ci-changes branch January 14, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyfast tonyfast tonyfast approved these changes

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshCasper @costrouc @tonyfast