Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take AWS region from AWS_DEFAULT_REGION into qhub-config.yaml on init… #950

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

danlester
Copy link
Contributor

…, but otherwise always respect the setting in qhub-config.yaml

Changes:

  • Ensures AWS region specified in qhub-config.yaml is always respected
  • Allows user to change that via AWS_DEFAULT_REGION env var going into qhub init

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

…, but otherwise always respect the setting in qhub-config.yaml
@danlester danlester merged commit cf46ab1 into main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant