Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate GCPPrivateClusterConfig class #2786

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Oct 22, 2024

Reference Issues or PRs

Fixes #2785

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

see that there is only one definition for the class.

Any other comments?

@dcmcand dcmcand added type: bug 🐛 Something isn't working status: in review 👀 This PR is currently being reviewed by the team labels Oct 22, 2024
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dcmcand dcmcand merged commit 98970ba into main Oct 22, 2024
28 checks passed
@dcmcand dcmcand deleted the remove-duplicate-class branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in review 👀 This PR is currently being reviewed by the team type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Duplicate class in src/_nebari/stages/infrastructure/__init__.py
2 participants