-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test workflow for upgrade #2780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing has changed functionally here. I factored out three things into local actions for them to be reusable by the upgrade test workflow:
- Setting up the runner for local deployments, i.e. installing kubectl and configuring docker
- Initializing the Nebari config and adding some CI specific options.
- Perform a health check for a nebari deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is a really well-built PR. It adds the new workflow pipeline for testing the upgrade path and helps modularize some parts of our workflow with custom self-actions. Once we remove the workaround below, we can merge this
Reference Issues or PRs
Addresses #2701 (comment).
closes #2867
What does this implement/fix?
Put a
x
in the boxes that applyThis PR adds a new CI workflow to test the happy path of upgrading Nebari. In particular it tests 3 things
nebari upgrade
works starting from the most recent releasenebari deploy
works after the config upgradeIt does not test
Testing
How to test this PR?
Look at the CI config and validate if the workflow follows the correct upgrade path and whether the signal is green.
Any other comments?