Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test implict aiohttp's TCP to HTTP connector change #2741

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Sep 25, 2024

There seems to be an issue with how dask or aiohttp calls the underlying proxy connector (that's decided based on the URL schema passed down as a parameter), which has changed recently. This is breaking our unit tests recently, this PR proposes a change to disable ssl checks made by the gateway client when running locally.

Reference Issues or PRs

closes #2744

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

viniciusdc and others added 3 commits September 25, 2024 13:25
There seems to be an issue with how dask or `aiohttp` calls the underlying proxy connector (that's decided based on the URL schema passed down as a parameter), which has changed recently. By updating this value to HTTP(s) instead, we should trigger a new behavior with the falling tests
@viniciusdc viniciusdc marked this pull request as ready for review September 25, 2024 21:08
@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Sep 25, 2024
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viniciusdc 🚀

@viniciusdc viniciusdc merged commit 1549693 into develop Sep 25, 2024
27 checks passed
@viniciusdc viniciusdc deleted the dask-gaeway-tests-ssl branch September 25, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - SSL Certificate Verification Failure in Dask Gateway Unit Tests
2 participants