Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include deprecation notes for init/deploy subcommands #2582

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Jul 26, 2024

Reference Issues or PRs

closes #2565

What does this implement/fix?

  • Adds a new message while selecting the available options during guided-init to inform the user that Digital Ocean (DO) support is being deprecated.
  • Includes a confirmation message when deploying clusters of DO, warning of the deprecation

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@viniciusdc viniciusdc requested a review from marcelovilla July 26, 2024 16:41
@viniciusdc
Copy link
Contributor Author

@marcelovilla @Adam-D-Lewis let me know what you think about the messages

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jul 26, 2024

I want to make sure users see this notice. If they deploy via github action then they won't see any warning. Could you add a note during the upgrade step as well?

@Adam-D-Lewis Adam-D-Lewis self-requested a review July 26, 2024 21:11
@viniciusdc
Copy link
Contributor Author

I agree, though I would prefer to add such note on a separate PR dedicated for the upgrade command & release.

@Adam-D-Lewis
Copy link
Member

I agree, though I would prefer to add such note on a separate PR dedicated for the upgrade command & release.

Cool, could you make an issue and attach it to the milestone so we don't forget?

@viniciusdc
Copy link
Contributor Author

I agree, though I would prefer to add such note on a separate PR dedicated for the upgrade command & release.

Cool, could you make an issue and attach it to the milestone so we don't forget?

Added as part of the release checklist under the upgrade command section #2592

@Adam-D-Lewis
Copy link
Member

@viniciusdc Looks like the Local Integration test is failing. Is it related to this PR?

@viniciusdc
Copy link
Contributor Author

@viniciusdc Looks like the Local Integration test is failing. Is it related to this PR?

doesn't look like its related to this, as the deployment succeeded and the tests are failing while running the notebooks. I will have a look in the video artifacts

@viniciusdc
Copy link
Contributor Author

also, btw, @Adam-D-Lewis I added a warning message to the update command #2594, let me know if that sounds good

@viniciusdc
Copy link
Contributor Author

looks like its related to the test itself, #2594 failed as well

@viniciusdc viniciusdc added this to the 2024.7.1 milestone Jul 29, 2024
@viniciusdc viniciusdc requested a review from marcelovilla July 29, 2024 20:15
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@viniciusdc viniciusdc merged commit aa63066 into develop Jul 29, 2024
29 checks passed
@viniciusdc viniciusdc deleted the 2565-DO-deprecation-warning branch July 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add digital ocean deprecation warning
3 participants