-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include deprecation notes for init/deploy subcommands #2582
Conversation
@marcelovilla @Adam-D-Lewis let me know what you think about the messages |
I want to make sure users see this notice. If they deploy via github action then they won't see any warning. Could you add a note during the upgrade step as well? |
I agree, though I would prefer to add such note on a separate PR dedicated for the upgrade command & release. |
Cool, could you make an issue and attach it to the milestone so we don't forget? |
Added as part of the release checklist under the upgrade command section #2592 |
@viniciusdc Looks like the Local Integration test is failing. Is it related to this PR? |
doesn't look like its related to this, as the deployment succeeded and the tests are failing while running the notebooks. I will have a look in the video artifacts |
also, btw, @Adam-D-Lewis I added a warning message to the update command #2594, let me know if that sounds good |
looks like its related to the test itself, #2594 failed as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Reference Issues or PRs
closes #2565
What does this implement/fix?
guided-init
to inform the user that Digital Ocean (DO) support is being deprecated.Put a
x
in the boxes that applyTesting
Any other comments?