Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix general node scaling bug for azure #2517

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Jun 18, 2024

Reference Issues or PRs

Fixes #2516

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching it @Adam-D-Lewis

@viniciusdc
Copy link
Contributor

viniciusdc commented Jun 18, 2024

Also, it's pretty interesting to discover that the order of our default node groups in our configuration matters.

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Jun 18, 2024

Also, it's pretty interesting to discover that the order of our default node groups in our configuration matters.

Oh yeah, I hope that's not the case. I hope we're making sure we pass in the general node group first to terraform at least regardless of it's order in nebari-config.yaml

@Adam-D-Lewis Adam-D-Lewis merged commit 71c2079 into develop Jun 18, 2024
27 of 28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the azure_general_node_scaling_fix branch June 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Azure General Node Group can't scale beyond a single node
2 participants