Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass current namespace to argo via environment variable #2317

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Mar 13, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@krassowski krassowski marked this pull request as ready for review March 13, 2024 17:57
@dcmcand dcmcand requested a review from viniciusdc March 18, 2024 15:32
@viniciusdc
Copy link
Contributor

Hi @krassowski this LGTM, I just need to make sure all the vars are defined already and have some defaults. Then we can merge

@viniciusdc viniciusdc added this to the 2024.3.3 milestone Mar 23, 2024
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with GCP, needs a new release of the docker images that contains the released version (see PR) of the argo-jupyter-scheduler , but can be merged.

@krassowski krassowski merged commit 9b9b6bc into nebari-dev:develop Mar 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Scheduler does not work when argo workflows are disabled
2 participants