Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove flake8 from dependencies #2044

Merged
merged 2 commits into from
Oct 9, 2023
Merged

CLN: remove flake8 from dependencies #2044

merged 2 commits into from
Oct 9, 2023

Conversation

fangchenli
Copy link
Member

Reference Issues or PRs

follow up #1602
xref #1589

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@fangchenli fangchenli marked this pull request as ready for review October 2, 2023 18:00
@iameskild iameskild added type: maintenance 🛠 Day-to-day maintenance tasks area: dependencies 📦 All things dependencies labels Oct 9, 2023
iameskild
iameskild approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli!!

@iameskild iameskild merged commit 8e181bd into nebari-dev:develop Oct 9, 2023
@fangchenli fangchenli deleted the remove-flake8 branch October 22, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦 All things dependencies type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @iameskild