Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify JupyterHub networkPolicy to match existing policy #1991

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Fixes #1965

Having the CHP networkPolicy enabled for JupyterHub deployed to AWS, Azure and GCP was no trouble so I'm not sure why this only seems to affect Digital Ocean. We also have the networkPolicy disabled for hub and singleuser already.

We should definitely test this change on the other clouds before merging - I don't expect this to cause problems since removing the network policy makes internal networking more permissible.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild
Copy link
Member Author

@costrouc do you see any reason why we shouldn't disabled the chp.networkPolicy?

@pavithraes pavithraes requested a review from costrouc September 11, 2023 13:43
@pavithraes pavithraes added the status: in review 👀 This PR is currently being reviewed by the team label Sep 11, 2023
@iameskild iameskild changed the title Disable networkPolicy for JHub chp Modify JupyterHub networkPolicy to match existing policy Sep 12, 2023
Copy link
Contributor

@sblair-metrostar sblair-metrostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iameskild
Copy link
Member Author

@pavithraes @kcpevey could you please review?

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavithraes pavithraes merged commit a427f87 into develop Sep 14, 2023
@pavithraes pavithraes deleted the fix_1965 branch September 14, 2023 15:21
@pavithraes pavithraes removed the status: in review 👀 This PR is currently being reviewed by the team label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - JupyterHub 3 failing on Digital Ocean
3 participants