-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make nebari API private #1778
make nebari API private #1778
Conversation
1a55a34
to
c32a296
Compare
💰 Infracost estimate: monthly cost will not change
8 projects have no cost estimate changes. Infracost output
This comment will be updated when the cost estimate changes. Is this comment useful? Yes, No, Other |
84a7290
to
62379f4
Compare
All CI failures on 62379f4 are tracked in #1817. As discussed in yesterday's community meeting, I'm going to ignore these and move forward with the PR. |
Same deal as in #1778 (comment) with be85b66 and 3181f57. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me @pmeier and I'm in favor of merging this earlier rather than later. Once you give the merge conflicts I'm in favor of immediately merging.
I like our minimal nebari interface now of nebari/__init__.py
and nebari/__main__.py
Implements 4. of nebari-dev/governance#37 in three steps:
src/nebari
layout. Right now we have the package directly in our repository root. Since we will ultimately have anebari
as well as a_nebari
package, it is useful to tuck them together in one folder. This is done bypytest
, which we are following with this API change, and many other Python projects as well.nebari
package private by renaming it to_nebari
.nebari
package that does nothing but expose the CLI and a__version__
attribute.I'll send one commit per step outlined above to make it easier to review. Since the diff will get quite large, I advise reviewers to go commit by commit.
This PR will conflict with basically every other open PR and every patch that was merged into
develop
after I have started. To keep disruption to a minimum, I plan to only rebase once after this PR has been approved. For all other open PRs, I'm available for helping to migrate them. Tag me there if you need help.