Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conda forge explicitly in conda build test #1771

Merged
merged 1 commit into from
May 9, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 2, 2023

What does this implement/fix?

This PR adds --channel=conda-forge explicitly to the conda build we are running as part of our tests. Right now our CI relies on this being set in the conda configuration file:

channels: conda-forge

However, we cannot depend on this being the case locally for all other devs as well. Without setting the channel explicitly, conda build will try to pull from the defaults channel and fail, since it doesn't contain everything we need.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@trallard
Copy link
Member

trallard commented May 2, 2023

@dharhas I think I found the culprit of the conda build issue we encountered during the sprints

In hindsight, I wonder if this test needs to be run at all times or only during a pre-build/pre-packaging stage

@pavithraes pavithraes added the needs: review 👀 This PR is complete and ready for reviewing label May 3, 2023
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and we should be using conda-forge by default anyways. Thanks @pmeier

@costrouc costrouc merged commit 18e7eaa into nebari-dev:develop May 9, 2023
@pmeier pmeier deleted the conda-build branch May 9, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:developer-experience 👩🏻‍💻 needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

4 participants