Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secret token in release-notes-sync action #1753

Merged

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Apr 25, 2023

Reference Issues or PRs

#1751

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added type: bug 🐛 Something isn't working area: documentation 📖 Improvements or additions to documentation status: in progress 🏗 This task is currently being worked on labels Apr 25, 2023
@pavithraes pavithraes self-assigned this Apr 25, 2023
@pavithraes pavithraes requested a review from iameskild April 25, 2023 17:21
@pavithraes pavithraes changed the title [WIP] Update secret token in release-notes-sync action Update secret token in release-notes-sync action Apr 25, 2023
@pavithraes
Copy link
Member Author

pavithraes commented Apr 25, 2023

@pavithraes pavithraes added needs: review 👀 This PR is complete and ready for reviewing and removed status: in progress 🏗 This task is currently being worked on labels Apr 26, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavithraes reading through the action README, we need to ensure the token is a PAT - which looks like it is in this PR. I say we make this change and I can test that this is resolved by creating a dev pre-release.

@pavithraes
Copy link
Member Author

@iameskild Thank you, I'll merge! We can also trigger it with a dispatch event -- I can try this immediately. :)

@pavithraes pavithraes merged commit 1cf92c1 into nebari-dev:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing type: bug 🐛 Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants