Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removal of the isMobile check in Nightly #1208

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

Pawel-Szydlo
Copy link
Contributor

@Pawel-Szydlo Pawel-Szydlo commented Sep 25, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@frol
Copy link
Collaborator

frol commented Sep 30, 2024

@Pawel-Szydlo does nightly work well on mobile now?

@Pawel-Szydlo
Copy link
Contributor Author

Pawel-Szydlo commented Sep 30, 2024

@Pawel-Szydlo does nightly work well on mobile now?
@frol
yes, the whole network runs smoothly, we want to enable users to use browsers inside the application. however, the code left over, blocks us from doing so.

@Pawel-Szydlo
Copy link
Contributor Author

Hi, is everything ok with PR or do I need to improve something? @frol

@Emadalshamery Emadalshamery mentioned this pull request Nov 13, 2024
gagdiez
gagdiez previously approved these changes Jan 28, 2025
@trechriron trechriron self-requested a review February 6, 2025 15:34
trechriron
trechriron previously approved these changes Feb 6, 2025
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trechriron trechriron changed the base branch from main to dev February 6, 2025 15:34
@trechriron trechriron dismissed stale reviews from gagdiez and themself February 6, 2025 15:34

The base branch was changed.

@github-actions github-actions bot changed the title Removal of the isMobile check in Nightly fix: Removal of the isMobile check in Nightly Feb 6, 2025
@trechriron trechriron merged commit 081db5d into near:dev Feb 6, 2025
12 checks passed
@trechriron trechriron mentioned this pull request Feb 6, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

4 participants