RoutingTableView: add nonces, display tombstone edges separately #9560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhi3030
approved these changes
Sep 25, 2023
|
Thanks to @robin-near the debug UI is now strongly typed. Between that and some basic manual testing to verify the output (screenshot attached above), we can be reasonably confident there are no issues. |
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
RoutingTableView contains a table Direct Peers with one entry per peer. The table displays the latest distance vector shared by each peer. This PR: - Adds the Min Nonce for each distance vector to the display, indicating the age of the received information. - Moves any peers in a disconnected state to a separate table for clarity. <img width="1448" alt="image" src="/~https://github.com/near/nearcore/assets/3241341/8488eb07-7adf-4c7c-838e-165ca740d2fa">
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
RoutingTableView contains a table Direct Peers with one entry per peer. The table displays the latest distance vector shared by each peer. This PR: - Adds the Min Nonce for each distance vector to the display, indicating the age of the received information. - Moves any peers in a disconnected state to a separate table for clarity. <img width="1448" alt="image" src="/~https://github.com/near/nearcore/assets/3241341/8488eb07-7adf-4c7c-838e-165ca740d2fa">
Thanks for the explanation! |
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
RoutingTableView contains a table Direct Peers with one entry per peer. The table displays the latest distance vector shared by each peer. This PR: - Adds the Min Nonce for each distance vector to the display, indicating the age of the received information. - Moves any peers in a disconnected state to a separate table for clarity. <img width="1448" alt="image" src="/~https://github.com/near/nearcore/assets/3241341/8488eb07-7adf-4c7c-838e-165ca740d2fa">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoutingTableView contains a table Direct Peers with one entry per peer. The table displays the latest distance vector shared by each peer.
This PR: