refactor: add EpochManagerAdapter infra #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of near#6910 The grand plan is to separate EpochManager out of NightshadeRuntime. As a first step, I want to separate the *types* of runtime and epoch manager, while keeping them in the same object. I want to do this via the following series of steps: ``` trait RuntimeAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter: EpochManagerAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter {} ``` This PR introduces the EpochManagerAdapter infra. You can see the rough idea of the plan in near#7606
Just to show how it works! Expect this repeated a bunch of times soon!
This was referenced Sep 21, 2022
mm-near
approved these changes
Sep 21, 2022
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2022
Part of #6910 The grand plan is to separate EpochManager out of NightshadeRuntime. As a first step, I want to separate the *types* of runtime and epoch manager, while keeping them in the same object. I want to do this via the following series of steps: ``` trait RuntimeAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter: EpochManagerAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter {} ``` This PR introduces the EpochManagerAdapter infra. You can see the rough idea of the plan in #7606
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Part of #6910 The grand plan is to separate EpochManager out of NightshadeRuntime. As a first step, I want to separate the *types* of runtime and epoch manager, while keeping them in the same object. I want to do this via the following series of steps: ``` trait RuntimeAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter: EpochManagerAdapter {} ``` ``` trait EpochManagerAdapter {} trait RuntimeAdapter {} ``` This PR introduces the EpochManagerAdapter infra. You can see the rough idea of the plan in #7606
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6910
The grand plan is to separate EpochManager out of NightshadeRuntime. As
a first step, I want to separate the types of runtime and epoch
manager, while keeping them in the same object. I want to do this via
the following series of steps:
This PR introduces the EpochManagerAdapter infra.
You can see the rough idea of the plan in #7606