Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resharding] Add V2->V3 integration tests #10734

Merged

Conversation

shreyan-gupta
Copy link
Contributor

Please only refer to the last commit 7b289c9e763e96b6c863baeb7b80f9ec9c638620 or changes in file integration-tests/src/tests/client/resharding.rs

I'm unable to create stacked PRs for my forked repo.

To be merged only after #10725

@shreyan-gupta shreyan-gupta requested a review from wacban March 8, 2024 11:43
@shreyan-gupta shreyan-gupta marked this pull request as ready for review March 8, 2024 11:44
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner March 8, 2024 11:44
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm not accepting for now, until we are fully committed to the V3 resharding.

@@ -50,26 +53,31 @@ enum ReshardingType {
V1,
// In the V1->V2 resharding outgoing receipts are reassigned to lowest index child.
V2,
// In the V1->V2 resharding outgoing receipts are reassigned to lowest index child.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: V2->V3

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (0efb74b) to head (d3eed31).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10734   +/-   ##
=======================================
  Coverage   71.66%   71.67%           
=======================================
  Files         758      758           
  Lines      152788   152788           
  Branches   152788   152788           
=======================================
+ Hits       109503   109508    +5     
+ Misses      38325    38312   -13     
- Partials     4960     4968    +8     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (ø)
db-migration 0.24% <ø> (ø)
genesis-check 1.42% <ø> (ø)
integration-tests 36.85% <ø> (-0.03%) ⬇️
linux 70.43% <ø> (-0.01%) ⬇️
linux-nightly 71.16% <ø> (ø)
macos 54.75% <ø> (+0.01%) ⬆️
pytests 1.65% <ø> (ø)
sanity-checks 1.43% <ø> (ø)
unittests 67.48% <ø> (-0.01%) ⬇️
upgradability 0.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban force-pushed the shreyan/resharding/v3_integration_test branch from faa4b47 to 5fa548b Compare March 11, 2024 15:58
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wacban wacban enabled auto-merge March 11, 2024 16:11
@wacban wacban added this pull request to the merge queue Mar 11, 2024
Merged via the queue into near:master with commit fe7ab16 Mar 11, 2024
30 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/resharding/v3_integration_test branch March 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants