-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resharding] Add V2->V3 integration tests #10734
[resharding] Add V2->V3 integration tests #10734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'm not accepting for now, until we are fully committed to the V3 resharding.
@@ -50,26 +53,31 @@ enum ReshardingType { | |||
V1, | |||
// In the V1->V2 resharding outgoing receipts are reassigned to lowest index child. | |||
V2, | |||
// In the V1->V2 resharding outgoing receipts are reassigned to lowest index child. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: V2->V3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10734 +/- ##
=======================================
Coverage 71.66% 71.67%
=======================================
Files 758 758
Lines 152788 152788
Branches 152788 152788
=======================================
+ Hits 109503 109508 +5
+ Misses 38325 38312 -13
- Partials 4960 4968 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
faa4b47
to
5fa548b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please only refer to the last commit
7b289c9e763e96b6c863baeb7b80f9ec9c638620
or changes in fileintegration-tests/src/tests/client/resharding.rs
I'm unable to create stacked PRs for my forked repo.
To be merged only after #10725