Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account creation transaction result checked #188

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Aug 8, 2022

Before: if the account was not created, we were throwing errors in the test itself. Usually, it was AccountDoesNotExist.
Now: we are throwing errors early so the user knows the account was not created and the real reason for it.

@volovyks volovyks requested review from ailisp and BenKurrek August 8, 2022 12:26
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@volovyks
Copy link
Collaborator Author

Looks like now we have strict rules on the RPC side. I'm getting "Please try again in 30 seconds." error in Testnet mode. I'm turning off testnet tests for now.

@volovyks volovyks merged commit b52599f into main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants