Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #111

Merged
merged 3 commits into from
Oct 4, 2022
Merged

chore: update deps #111

merged 3 commits into from
Oct 4, 2022

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented Oct 3, 2022

Updated some, and just loosened the semver constraints for “trusted” dependencies.

@matklad, what do you think? Is this an antipattern?

@miraclx miraclx requested a review from matklad October 3, 2022 05:12
@miraclx miraclx mentioned this pull request Oct 3, 2022
@matklad
Copy link

matklad commented Oct 3, 2022

Yeah, I think it's better to stick with full semver here

https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277/13?u=matklad

It is a small mistake either way though!

@miraclx
Copy link
Contributor Author

miraclx commented Oct 4, 2022

Very interesting read. I'll go ahead to retain full semver. Thanks for the insight.

@miraclx miraclx merged commit ce4258f into master Oct 4, 2022
@miraclx miraclx deleted the update-deps branch October 4, 2022 00:59
@frol frol mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants