Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE and README into built gem package #126

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Envek
Copy link
Contributor

@Envek Envek commented Jun 21, 2023

Today I noticed that only lib/ and sig/ folders are packaged into .gem file on release. However, RubyGems gem specification reference guides that full license test should be placed into the built gem (emphasis is mine):

This should just be the name of your license. The full text of the license should be inside of the gem (at the top level) when you build it.

Also added the README file for unfortunate (but unlikely) case if someone will be forced to work with the gem without Internet access (e.g. debugging an application deployed in isolated internal enterprise network).

@wallyqs wallyqs merged commit 56f5b96 into nats-io:main Jun 21, 2023
@Envek Envek deleted the chore/include-license-into-gem branch June 22, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants