Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makewin.bat右键以管理员身份运行时会出现bug #29

Merged
merged 2 commits into from
May 21, 2017

Conversation

IOriens
Copy link
Contributor

@IOriens IOriens commented May 19, 2017

Tested on Windows 10, not sure if it works on Windows 7/8 or former Windows platform.

@nanmu42 nanmu42 self-assigned this May 21, 2017
@nanmu42 nanmu42 self-requested a review May 21, 2017 04:46
@nanmu42 nanmu42 changed the title fix: file not found err on win platform fix: 右键以管理员身份运行时会出现bug May 21, 2017
@nanmu42 nanmu42 changed the title fix: 右键以管理员身份运行时会出现bug fix: makewin.bat右键以管理员身份运行时会出现bug May 21, 2017
Copy link
Owner

@nanmu42 nanmu42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你的贡献!
但是,我测试了一下,目前这个PR似乎仍然没能解决在管理员身份下的dtx无法解包的问题。

@nanmu42
Copy link
Owner

nanmu42 commented May 21, 2017

image
看起来,路径的更改似乎有作用域?

makewin.bat Outdated
:: we need to change directory to where this script exists
echo Current path is %cd%
echo Changing directory to the path of the current script
cd %~dp0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处需要使用:

cd /d %~dp0

才能保证在跨磁盘环境下也正常工作。

Copy link
Owner

@nanmu42 nanmu42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你的贡献!
Cheers!

@nanmu42 nanmu42 merged commit 972ade6 into nanmu42:master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants