Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/386 class summary min can be 0 #387

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

nagyesta
Copy link
Owner

Issue: #386 , N/A

Description

  • Fixed merge method to avoid unnecessary comparisons with null
  • Adds total stats to the bottom of the event log section

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

  • Added a minor cosmetic feature as well to avoid a double release.

nagyesta added 2 commits June 26, 2023 21:16
- Fixed merge method to avoid unnecessary comparisons with null

Resolves #386
{patch}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
- Adds total stats to the bottom of the event log section

{patch}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta self-assigned this Jun 26, 2023
@nagyesta nagyesta added the bug Something isn't working label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #387 (0aa724a) into main (23ca0cf) will increase coverage by 2.61%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #387      +/-   ##
============================================
+ Coverage     89.54%   92.15%   +2.61%     
+ Complexity      707       51     -656     
============================================
  Files            99       22      -77     
  Lines          2880     1301    -1579     
  Branches        267      179      -88     
============================================
- Hits           2579     1199    -1380     
+ Misses          231       74     -157     
+ Partials         70       28      -42     
Flag Coverage Δ
core ?
cucumber ∅ <ø> (∅)
flighteval 92.15% <100.00%> (+0.01%) ⬆️
junit4 ?
jupiter ?
testkit ∅ <ø> (∅)
testng ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on-report/flight-evaluation-report/node/src/app.js 91.05% <100.00%> (+0.22%) ⬆️
...ht-evaluation-report/node/src/detail-view-model.js 92.61% <100.00%> (ø)

... and 77 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nagyesta nagyesta merged commit 31bbda0 into main Jun 26, 2023
@nagyesta nagyesta deleted the bugfix/386-class-summary-min-can-be-0 branch June 26, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant