Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail telemetry conversion when no measurements are found in the JSON #124

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

nagyesta
Copy link
Owner

Issue: #123

Description

  • Flight Evaluation Report will fail in case the JSON has no measurements in it
  • Updates dependencies which became outdated due to Renovate error

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Flight Evaluation Report will fail in case the JSON has no measurements in it
- Updates dependencies which became outdated due to Renovate error

Resolves #123
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta self-assigned this Aug 10, 2022
@nagyesta nagyesta added the enhancement New feature or request label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #124 (aaeecd0) into main (269d05a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
+ Coverage     91.68%   91.70%   +0.01%     
- Complexity      862      863       +1     
============================================
  Files           117      117              
  Lines          2334     2338       +4     
  Branches         98       99       +1     
============================================
+ Hits           2140     2144       +4     
  Misses          161      161              
  Partials         33       33              
Flag Coverage Δ
core 95.02% <ø> (ø)
cucumber 93.45% <ø> (ø)
flighteval 93.44% <100.00%> (+0.07%) ⬆️
h2 99.15% <ø> (ø)
junit4 82.45% <ø> (ø)
jupiter 86.36% <ø> (ø)
rmi 92.88% <ø> (ø)
strongback 100.00% <ø> (ø)
testkit 21.51% <ø> (ø)
testng 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ion/reporting/controller/ConversionController.java 85.93% <100.00%> (+0.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nagyesta nagyesta merged commit 899d708 into main Aug 10, 2022
@nagyesta nagyesta deleted the feature/123-fail-if-telemetry-is-empty branch August 10, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant