Fix - anchor tag breaks into parts with partial styling

[bartgloudemans]

Proposed fix for #59

this is a breaking change as Link->wrapper is discarded

this closes #59

[nadar]

Hi @bartgloudemans thanks for the PR (and issue!). This will break quite a few things and i need to take a deeper look. So the unit tests should not fail.

The php docs and @SInCE tags are missing, also we need to make a major release (which is not a problem, just saying)

[bartgloudemans]

@nadar thanks for allowing the tests to run.
I will pay additional attention to docs/tags as you mentioned and try and fix the failing checks.

This proposed fix is one approach to tackle the issue, based on my limited knowledge of the quill-delta-parser. I'm curious if you maybe have a completely different approach in mind that I'm overlooking.
I'm especially interested because this link+italic example is a dressed down version of the issue I'm actually having with a more complex custom listener. My custom listener acts instead of the link listener and adds a complex piece of html into the rendered html. And that complex html is much harder to break down than the simple "wrapperOpen", "wrapperMiddle" and "wrapperClose".

[nadar]

@bartgloudemans thanks for the work! I will take a closer look within the next 48hours.

(edited: but in general, if the unit tests work, which cover a lot of different content situations, your proposed fix seems to be a good solution anyhow!)

I'm especially interested because this link+italic example is a dressed down version of the issue I'm actually having with a more complex custom listener. My custom listener acts instead of the link listener and adds a complex piece of html into the rendered html. And that complex html is much harder to break down than the simple "wrapperOpen", "wrapperMiddle" and "wrapperClose".

Would you like to share your custom listener?

[bartgloudemans]

In the mean time I've fixed my custom listener, it appeared not to be so complex after all.

The 'complexity' lies in the fact that Instead of a string attribute named 'wrapper', it renders a template based on dynamic data. So I needed to split up (explode()) the rendered template into 'wrapperOpen' and 'wrapperClose'. From there the approach is the same as in this PR.

Is there anything else you need from me to move this PR forward?

[nadar]

@bartgloudemans thanks for the work, i really appreciate it. I will make some small changes in upgrade docs and release version 3.0 asap.

[nadar]

Version 3.0 is published. /~https://github.com/nadar/quill-delta-parser/releases/tag/3.0.0