Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 267 #269

Merged
merged 2 commits into from
Jun 22, 2021
Merged

fix bug 267 #269

merged 2 commits into from
Jun 22, 2021

Conversation

Zhaoyu1123
Copy link

@Zhaoyu1123 Zhaoyu1123 commented Jun 17, 2021

Initialize Serviceinfomap whether or not local cache is loaded
fix:#267

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (2.0.0@9eef032). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             2.0.0     #269   +/-   ##
========================================
  Coverage         ?   32.11%           
========================================
  Files            ?       31           
  Lines            ?     1918           
  Branches         ?        0           
========================================
  Hits             ?      616           
  Misses           ?     1252           
  Partials         ?       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eef032...e90b25c. Read the comment docs.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 8456237 into nacos-group:2.0.0 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants